fix: suppress compiler warnings

embrace-io · May 8, 2024 · d1c114b · d1c114b
1 parent b44ff17
commit d1c114b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/...droid-sdk/src/main/java/io/embrace/android/embracesdk/capture/envelope/resource/Device.kt b/...droid-sdk/src/main/java/io/embrace/android/embracesdk/capture/envelope/resource/Device.kt
@@ -109,6 +109,7 @@ internal class DeviceImpl(
  }
  }
 
+ @Suppress("DEPRECATION")
  private fun getScreenResolution(windowManager: WindowManager?): String {
  return try {
  val display = windowManager?.defaultDisplay

diff --git a/...ava/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt b/...ava/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
@@ -21,6 +21,7 @@ internal class EnvelopeResourceSourceImpl(
  private val metadataService: MetadataService
 ) : EnvelopeResourceSource {
 
+ @Suppress("DEPRECATION")
  override fun getEnvelopeResource(): EnvelopeResource {
  return EnvelopeResource(
  appVersion = packageInfo.versionName?.toString()?.trim { it <= ' ' } ?: "",

diff --git a/...dk/src/main/java/io/embrace/android/embracesdk/capture/metadata/EmbraceMetadataService.kt b/...dk/src/main/java/io/embrace/android/embracesdk/capture/metadata/EmbraceMetadataService.kt
@@ -128,7 +128,7 @@ internal class EmbraceMetadataService private constructor(
  }
  }
 
- @SuppressWarnings("deprecation")
+ @Suppress("DEPRECATION")
  private fun asyncRetrieveScreenResolution() {
  // if the screenResolution exists in memory, don't try to retrieve it
  if (!screenResolution.isNullOrEmpty()) {
@@ -189,8 +189,8 @@ internal class EmbraceMetadataService private constructor(
  }
  }
 
+ @Suppress("DEPRECATION")
  @TargetApi(Build.VERSION_CODES.O)
- @SuppressWarnings("deprecation")
  fun getDeviceDiskAppUsage(
  storageStatsManager: StorageStatsManager?,
  packageManager: PackageManager,

diff --git a/...android-sdk/src/main/java/io/embrace/android/embracesdk/internal/spans/EmbraceSpanImpl.kt b/...android-sdk/src/main/java/io/embrace/android/embracesdk/internal/spans/EmbraceSpanImpl.kt
@@ -63,7 +63,7 @@ internal class EmbraceSpanImpl(
  }
  if (successful) {
  spanStartTimeMs = attemptedStartTimeMs
- spanRepository?.trackStartedSpan(this)
+ spanRepository.trackStartedSpan(this)
  }
  return successful
  }
@@ -107,7 +107,7 @@ internal class EmbraceSpanImpl(
  Span.Status.OK
  }
  spanEndTimeMs = attemptedEndTimeMs
- spanId?.let { spanRepository?.trackedSpanStopped(it) }
+ spanId?.let { spanRepository.trackedSpanStopped(it) }
  }
  return successful
  }

diff --git a/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/FakeLogOrchestrator.kt b/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/FakeLogOrchestrator.kt
@@ -6,7 +6,7 @@ internal class FakeLogOrchestrator : LogOrchestrator {
 
  var flushCalled = false
 
- override fun flush(sync: Boolean) {
+ override fun flush(saveOnly: Boolean) {
  flushCalled = true
  }
 }
diff --git a/...android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/injection/FakeCoreModule.kt b/...android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/injection/FakeCoreModule.kt
@@ -32,6 +32,7 @@ internal class FakeCoreModule(
  override val resources: FakeAndroidResourcesService = FakeAndroidResourcesService(),
  override val isDebug: Boolean = if (isMockKMock(context)) false else AppEnvironment(context.applicationInfo).isDebug,
  override val buildInfo: BuildInfo = BuildInfo.fromResources(resources, context.packageName),
+ @Suppress("DEPRECATION")
  override val packageInfo: PackageInfo = context.packageManager.getPackageInfo(context.packageName, 0)
 ) : CoreModule {