Remove unused method

embrace-io · Mar 18, 2024 · bb4ad6b · bb4ad6b
1 parent 22a89d0
commit bb4ad6b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 47 deletions.
diff --git a/...android-sdk/src/main/java/io/embrace/android/embracesdk/event/EmbraceLogMessageService.kt b/...android-sdk/src/main/java/io/embrace/android/embracesdk/event/EmbraceLogMessageService.kt
@@ -123,26 +123,6 @@ internal class EmbraceLogMessageService(
  }
  }
 
- override fun log(
- message: String,
- type: EventType,
- properties: Map<String, Any>?
- ) {
- log(
- message,
- type,
- LogExceptionType.NONE,
- properties,
- null,
- null,
- AppFramework.NATIVE,
- null,
- null,
- null,
- null
- )
- }
-
  @Suppress("CyclomaticComplexMethod", "ComplexMethod", "LongParameterList")
  override fun log(
  message: String,

diff --git a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/event/LogMessageService.kt b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/event/LogMessageService.kt
@@ -18,19 +18,6 @@ internal interface LogMessageService : MemoryCleanerListener {
  */
  fun logNetwork(networkCaptureCall: NetworkCapturedCall?)
 
- /**
- * Creates a remote log.
- *
- * @param message the message to log
- * @param type the type of message to log, which must be INFO_LOG, WARNING_LOG, or ERROR_LOG
- * @param properties custom properties to send as part of the event
- */
- fun log(
- message: String,
- type: EventType,
- properties: Map<String, Any>?
- )
-
  /**
  * Creates a remote log.
  *

diff --git a/...oid-sdk/src/test/java/io/embrace/android/embracesdk/event/EmbraceLogMessageServiceTest.kt b/...oid-sdk/src/test/java/io/embrace/android/embracesdk/event/EmbraceLogMessageServiceTest.kt
@@ -136,9 +136,9 @@ internal class EmbraceLogMessageServiceTest {
  logMessageService = getLogMessageService()
 
  val props = mapOf("foo" to "bar")
- logMessageService.log("Hello world", EventType.INFO_LOG, props)
- logMessageService.log("Warning world", EventType.WARNING_LOG, null)
- logMessageService.log("Hello errors", EventType.ERROR_LOG, null)
+ simpleLog("Hello world", EventType.INFO_LOG, props)
+ simpleLog("Warning world", EventType.WARNING_LOG, null)
+ simpleLog("Hello errors", EventType.ERROR_LOG, null)
 
  val logs = deliveryService.lastSentLogs
  assertEquals(3, logs.size)
@@ -241,7 +241,7 @@ internal class EmbraceLogMessageServiceTest {
  @Test
  fun testDefaultMaxMessageLength() {
  logMessageService = getLogMessageService()
- logMessageService.log("Hi".repeat(65), EventType.INFO_LOG, null)
+ simpleLog("Hi".repeat(65), EventType.INFO_LOG, null)
 
  val message = deliveryService.lastSentLogs.single()
  assertTrue(message.event.name == "Hi".repeat(62) + "H...")
@@ -257,7 +257,7 @@ internal class EmbraceLogMessageServiceTest {
  )
 
  logMessageService = getLogMessageService()
- logMessageService.log("Hi".repeat(50), EventType.INFO_LOG, null)
+ simpleLog("Hi".repeat(50), EventType.INFO_LOG, null)
 
  val message = deliveryService.lastSentLogs.single()
  assertTrue(message.event.name == "Hi".repeat(23) + "H...")
@@ -268,8 +268,8 @@ internal class EmbraceLogMessageServiceTest {
  cfg = cfg.copy(disabledEventAndLogPatterns = setOf("Hello World"))
  logMessageService = getLogMessageService()
 
- logMessageService.log("Hello World", EventType.INFO_LOG, null)
- logMessageService.log("Another", EventType.INFO_LOG, null)
+ simpleLog("Hello World", EventType.INFO_LOG, null)
+ simpleLog("Another", EventType.INFO_LOG, null)
 
  deliveryService.lastSentLogs.single().let {
  assertEquals("Another", it.event.name)
@@ -281,9 +281,9 @@ internal class EmbraceLogMessageServiceTest {
  logMessageService = getLogMessageService()
 
  repeat(500) { k ->
- logMessageService.log("Test info $k", EventType.INFO_LOG, null)
- logMessageService.log("Test warning $k", EventType.WARNING_LOG, null)
- logMessageService.log("Test error $k", EventType.ERROR_LOG, null)
+ simpleLog("Test info $k", EventType.INFO_LOG, null)
+ simpleLog("Test warning $k", EventType.WARNING_LOG, null)
+ simpleLog("Test error $k", EventType.ERROR_LOG, null)
  }
 
  assertEquals(100, logMessageService.findInfoLogIds(0L, Long.MAX_VALUE).size)
@@ -392,6 +392,9 @@ internal class EmbraceLogMessageServiceTest {
  assertFalse(logMessageService.checkIfShouldGateLog(EventType.WARNING_LOG))
  }
 
+ private fun simpleLog(message: String, severity: EventType, properties: Map<String, Any>?) {
+ logMessageService.log(message, severity, LogExceptionType.NONE, properties, null, null, Embrace.AppFramework.NATIVE, null, null, null, null)
+ }
  private fun buildCustomRemoteConfig(components: Set<String>?, fullSessionEvents: Set<String>? = null) =
  RemoteConfig(
  sessionConfig = SessionRemoteConfig(

diff --git a/...ce-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/FakeLogMessageService.kt b/...ce-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/FakeLogMessageService.kt
@@ -14,10 +14,6 @@ internal class FakeLogMessageService : LogMessageService {
  networkCaptureCall?.let(networkCalls::add)
  }
 
- override fun log(message: String, type: EventType, properties: Map<String, Any>?) {
- TODO("Not yet implemented")
- }
-
  override fun log(
  message: String,
  type: EventType,