Skip to content

Commit

Permalink
Fix detekt.
Browse files Browse the repository at this point in the history
  • Loading branch information
lucaslabari committed Jan 8, 2024
1 parent 096e1f4 commit 8163550
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import io.embrace.android.embracesdk.comms.delivery.EmbraceCacheService
import io.embrace.android.embracesdk.comms.delivery.EmbraceDeliveryCacheManager
import io.embrace.android.embracesdk.storage.EmbraceStorageManager
import io.embrace.android.embracesdk.storage.StorageManager
import io.embrace.android.embracesdk.worker.ExecutorName
import io.embrace.android.embracesdk.worker.WorkerName
import io.embrace.android.embracesdk.worker.WorkerThreadModule
import java.io.File

Expand All @@ -24,8 +24,8 @@ internal class StorageModuleImpl(
coreModule: CoreModule,
) : StorageModule {

private val deliveryCacheExecutorService =
workerThreadModule.backgroundExecutor(ExecutorName.DELIVERY_CACHE)
private val deliveryCacheWorker =
workerThreadModule.backgroundWorker(WorkerName.DELIVERY_CACHE)

override val storageManager: StorageManager by singleton {
EmbraceStorageManager(coreModule)
Expand All @@ -45,7 +45,7 @@ internal class StorageModuleImpl(
override val deliveryCacheManager: DeliveryCacheManager by singleton {
EmbraceDeliveryCacheManager(
cacheService,
deliveryCacheExecutorService,
deliveryCacheWorker,
coreModule.logger,
initModule.clock,
coreModule.jsonSerializer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -489,20 +489,20 @@ internal class EmbraceNdkService(
)
}

// delete map files that don't have matching crash files
val mapFiles = getNativeMapFiles()
for (mapFile in mapFiles) {
if (hasNativeCrashFile(mapFile)) {
logger.logDeveloper(
"EmbraceNDKService",
"Skipping map file as it has a matching crash file " + mapFile.absolutePath
)
continue
}
mapFile.delete()
// delete map files that don't have matching crash files
val mapFiles = getNativeMapFiles()
for (mapFile in mapFiles) {
if (hasNativeCrashFile(mapFile)) {
logger.logDeveloper(
"EmbraceNDKService",
"Deleting map file as it has no matching crash file " + mapFile.absolutePath
"Skipping map file as it has a matching crash file " + mapFile.absolutePath

Check warning on line 498 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt#L498

Added line #L498 was not covered by tests
)
continue

Check warning on line 500 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt#L500

Added line #L500 was not covered by tests
}
mapFile.delete()
logger.logDeveloper(
"EmbraceNDKService",
"Deleting map file as it has no matching crash file " + mapFile.absolutePath

Check warning on line 505 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ndk/EmbraceNdkService.kt#L502-L505

Added lines #L502 - L505 were not covered by tests
)
}
}
Expand Down

0 comments on commit 8163550

Please sign in to comment.