Merge pull request #947 from embrace-io/remove-orientation-service

Remove unused orientation service

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/capture/internal/errors/InternalErrorType.kt

@@ -16,7 +16,6 @@ internal enum class InternalErrorType {
     BG_SESSION_CACHE_FAIL,
     FG_SESSION_CACHE_FAIL,
     ACTIVITY_LISTENER_FAIL,
-    ORIENTATION_CAPTURE_FAIL,
     PROCESS_STATE_CALLBACK_FAIL,
     TIME_TRAVEL,
     ANR_HEARTBEAT_CHECK_FAIL,

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/EssentialServiceModule.kt

@@ -10,8 +10,6 @@ import io.embrace.android.embracesdk.capture.metadata.AppEnvironment
 import io.embrace.android.embracesdk.capture.metadata.EmbraceMetadataService
 import io.embrace.android.embracesdk.capture.metadata.HostedSdkVersionInfo
 import io.embrace.android.embracesdk.capture.metadata.MetadataService
-import io.embrace.android.embracesdk.capture.orientation.NoOpOrientationService
-import io.embrace.android.embracesdk.capture.orientation.OrientationService
 import io.embrace.android.embracesdk.capture.user.EmbraceUserService
 import io.embrace.android.embracesdk.capture.user.UserService
 import io.embrace.android.embracesdk.comms.api.ApiClient
@@ -53,7 +51,6 @@ import io.embrace.android.embracesdk.worker.WorkerThreadModule
  */
 internal interface EssentialServiceModule {
     val memoryCleanerService: MemoryCleanerService
-    val orientationService: OrientationService
     val processStateService: ProcessStateService
     val activityLifecycleTracker: ActivityTracker
     val metadataService: MetadataService
@@ -145,19 +142,14 @@ internal class EssentialServiceModuleImpl(
         EmbraceMemoryCleanerService(logger = initModule.logger)
     }
 
-    override val orientationService: OrientationService by singleton {
-        // Embrace is not processing orientation changes on this moment, so return no-op service.
-        NoOpOrientationService()
-    }
-
     override val processStateService: ProcessStateService by singleton {
         Systrace.traceSynchronous("process-state-service-init") {
             EmbraceProcessStateService(initModule.clock, initModule.logger)
         }
     }
 
     override val activityLifecycleTracker: ActivityLifecycleTracker by singleton {
-        ActivityLifecycleTracker(coreModule.application, orientationService, initModule.logger)
+        ActivityLifecycleTracker(coreModule.application, initModule.logger)
     }
 
     override val configService: ConfigService by singleton {

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/session/lifecycle/ActivityLifecycleTracker.kt

@@ -5,7 +5,6 @@ import android.app.Application
 import android.os.Bundle
 import io.embrace.android.embracesdk.annotation.StartupActivity
 import io.embrace.android.embracesdk.capture.internal.errors.InternalErrorType
-import io.embrace.android.embracesdk.capture.orientation.OrientationService
 import io.embrace.android.embracesdk.logging.EmbLogger
 import io.embrace.android.embracesdk.utils.stream
 import java.lang.ref.WeakReference
@@ -16,7 +15,6 @@ import java.util.concurrent.CopyOnWriteArrayList
  */
 internal class ActivityLifecycleTracker(
     private val application: Application,
-    private val orientationService: OrientationService,
     private val logger: EmbLogger
 ) : ActivityTracker {
 
@@ -59,23 +57,8 @@ internal class ActivityLifecycleTracker(
             return foregroundActivity
         }
 
-    /**
-     * This method will update the current activity orientation.
-     *
-     * @param activity the activity involved in the tracking orientation process.
-     */
-    private fun updateOrientationWithActivity(activity: Activity) {
-        try {
-            orientationService.onOrientationChanged(activity.resources.configuration.orientation)
-        } catch (ex: Exception) {
-            logger.logWarning("Failed to register an orientation change")
-            logger.trackInternalError(InternalErrorType.ORIENTATION_CAPTURE_FAIL, ex)
-        }
-    }
-
     override fun onActivityCreated(activity: Activity, bundle: Bundle?) {
         updateStateWithActivity(activity)
-        updateOrientationWithActivity(activity)
         stream(listeners) { listener: ActivityLifecycleListener ->
             try {
                 listener.onActivityCreated(activity, bundle)

embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/EssentialServiceModuleImplTest.kt

@@ -5,7 +5,6 @@ import io.embrace.android.embracesdk.arch.destination.LogWriterImpl
 import io.embrace.android.embracesdk.capture.connectivity.EmbraceNetworkConnectivityService
 import io.embrace.android.embracesdk.capture.cpu.EmbraceCpuInfoDelegate
 import io.embrace.android.embracesdk.capture.metadata.EmbraceMetadataService
-import io.embrace.android.embracesdk.capture.orientation.NoOpOrientationService
 import io.embrace.android.embracesdk.capture.user.EmbraceUserService
 import io.embrace.android.embracesdk.comms.delivery.EmbracePendingApiCallsSender
 import io.embrace.android.embracesdk.config.EmbraceConfigService
@@ -55,7 +54,6 @@ internal class EssentialServiceModuleImplTest {
         ) { null }
 
         assertTrue(module.memoryCleanerService is EmbraceMemoryCleanerService)
-        assertTrue(module.orientationService is NoOpOrientationService)
         assertTrue(module.processStateService is EmbraceProcessStateService)
         assertTrue(module.metadataService is EmbraceMetadataService)
         assertNotNull(module.urlBuilder)

embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/injection/FakeEssentialServiceModule.kt

@@ -6,8 +6,6 @@ import io.embrace.android.embracesdk.capture.connectivity.NoOpNetworkConnectivit
 import io.embrace.android.embracesdk.capture.cpu.CpuInfoDelegate
 import io.embrace.android.embracesdk.capture.metadata.HostedSdkVersionInfo
 import io.embrace.android.embracesdk.capture.metadata.MetadataService
-import io.embrace.android.embracesdk.capture.orientation.NoOpOrientationService
-import io.embrace.android.embracesdk.capture.orientation.OrientationService
 import io.embrace.android.embracesdk.capture.user.UserService
 import io.embrace.android.embracesdk.comms.api.ApiClient
 import io.embrace.android.embracesdk.comms.api.ApiService
@@ -50,7 +48,6 @@ internal class FakeEssentialServiceModule(
     override val configService: ConfigService = FakeConfigService(),
     override val memoryCleanerService: MemoryCleanerService = FakeMemoryCleanerService(),
     override val gatingService: GatingService = FakeGatingService(),
-    override val orientationService: OrientationService = NoOpOrientationService(),
     override val apiClient: ApiClient = FakeApiClient(),
     override val userService: UserService = FakeUserService(),
     override val sharedObjectLoader: SharedObjectLoader = SharedObjectLoader(EmbLoggerImpl()),

embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt

@@ -7,7 +7,6 @@ import android.content.res.Resources
 import android.os.Bundle
 import android.os.Looper
 import io.embrace.android.embracesdk.fakes.FakeClock
-import io.embrace.android.embracesdk.fakes.FakeOrientationService
 import io.embrace.android.embracesdk.fakes.system.mockApplication
 import io.embrace.android.embracesdk.fakes.system.mockLooper
 import io.embrace.android.embracesdk.logging.EmbLoggerImpl
@@ -31,7 +30,6 @@ import org.junit.Test
 internal class ActivityLifecycleTrackerTest {
 
     private lateinit var activityLifecycleTracker: ActivityLifecycleTracker
-    private lateinit var orientationService: FakeOrientationService
 
     companion object {
         private lateinit var mockLooper: Looper
@@ -66,10 +64,8 @@ internal class ActivityLifecycleTrackerTest {
             staticMocks = false
         )
 
-        orientationService = FakeOrientationService()
         activityLifecycleTracker = ActivityLifecycleTracker(
             application,
-            orientationService,
             EmbLoggerImpl()
         )
     }
@@ -99,7 +95,6 @@ internal class ActivityLifecycleTrackerTest {
         activityLifecycleTracker.onActivityCreated(mockActivity, bundle)
 
         assertEquals(mockActivity, activityLifecycleTracker.foregroundActivity)
-        assertEquals(orientation, orientationService.changes.single())
         verify { mockActivityLifecycleListener.onActivityCreated(mockActivity, bundle) }
     }