Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes internal files used for swift demangling and replaces with package dependency on swift-demangling #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

atreat
Copy link

@atreat atreat commented Apr 11, 2024

Updates to use Swift Demangling package instead of managing this dependency inside this repo.

@atreat atreat force-pushed the atreat/integrate-swift-demangle branch from 19ca8c6 to 415b8c9 Compare May 7, 2024 15:19
@ArielDemarco
Copy link

Have you tried to compile on the other platforms? (watchOS / macOS / etc)

@atreat
Copy link
Author

atreat commented May 7, 2024

Have you tried to compile on the other platforms? (watchOS / macOS / etc)

Good call, probably need to edit the Mac.xcworkspace and WatchOS.xcworkspace. Will confirm

@atreat
Copy link
Author

atreat commented May 8, 2024

Looks like the Mac.xcworkspace and WatchOs.xcworkspace don't compile even on master.

@ArielDemarco
Copy link

I expressed myself wrong: i'd check if this compiles on the different platforms we support on 6.x (like, integrating it with Embrace and check if it keeps working)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants