This repository has been archived by the owner on May 26, 2019. It is now read-only.
Removed erroneous key= #1133
Merged
Removed erroneous key= #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With keys="@item", I get an error in the browser console: `Error: You must provide a string key when calling `yieldItem`; you provided undefined` This issue emberjs/ember.js#12109 mentions deleting `key=`, which fixed the issue.
|
Related to #1166 |
|
@homu r+ |
|
📌 Commit 4fe6f4e has been approved by |
homu
added a commit
that referenced
this pull request
Feb 4, 2016
Removed erroneous key= With keys="@item", I get an error in the browser console: `Error: You must provide a string key when calling `yieldItem`; you provided undefined` This issue emberjs/ember.js#12109 mentions deleting `key=`, which fixed the issue.
|
☀️ Test successful - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With keys="@item", I get an error in the browser console:
Error: You must provide a string key when callingyieldItem; you provided undefinedThis issue emberjs/ember.js#12109 mentions deleting
key=, which fixed the issue.