Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with `helm-occur' #112

Closed
Eoksni opened this issue Aug 27, 2014 · 3 comments
Closed

integration with `helm-occur' #112

Eoksni opened this issue Aug 27, 2014 · 3 comments
Assignees
Labels

Comments

@Eoksni
Copy link

Eoksni commented Aug 27, 2014

There is a package helm (https://github.com/emacs-helm/helm), successor of anything.
And there is helm-occur command (it is a replacement for usual occur).
It displays a list of found occurs, and by pressing C-j it makes main buffer show that particular occur in the buffer.

I managed to make helm buffers to be displayed in popup manner by adding (add-to-list 'popwin:special-display-config '("^\\*helm.*\\*$" :regexp t)).
But this helm-occur command misbehaves: after pressing C-j the *helm occur* window gets closed.

Here what it looks like:

After M-x helm-occur (notice *helm occur* window is there)
popwin-helm-occur-01

And after C-j (notice *helm occur* window is gone which shouldn't happen)
popwin-helm-occur-02

And, without popwin, how it should look like after C-j(notice *helm occur* window is there)
popwin-helm-occur-03

Running emacs -Q with init file:

;; adding package paths to `load-path'
;; ...

(require 'helm-config)

(require 'popwin)
(setq display-buffer-function 'popwin:display-buffer)
(add-to-list 'popwin:special-display-config '("^\\*helm.*\\*$" :regexp t))

GNU Emacs 24.3.1 (i386-mingw-nt6.2.9200) of 2013-03-18 on MARVIN
helm revision 32e0d5a (https://github.com/emacs-helm/helm)
popwin revision fe508ce

@m2ym
Copy link
Contributor

m2ym commented Aug 27, 2014

Perfect reporting. Thanks.

@m2ym m2ym self-assigned this Aug 27, 2014
@m2ym m2ym added the bug label Aug 27, 2014
@Eoksni
Copy link
Author

Eoksni commented Aug 27, 2014

Thanks for your kind words :)
In case you are not familiar with helm and going to investigate on this one, some additioinal info might be helpful for you:
helm can be easily installed with elpa;
the actual command behind that C-j is helm-execute-persistent-action IIRC

@m2ym
Copy link
Contributor

m2ym commented Sep 3, 2014

a9386cd

The problem is caused by calling sit-for within with-selected-window that causes popwin:close-popup-window-timer fired and the popup window closed.

@m2ym m2ym closed this as completed Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants