Add some commands #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display buffer is better choice than pop-to-buffer because most of the time the user wants to edit the query and see the result somewhere else without being forced to switch the active window. Also display-buffer is customizable via display-buffer-alist settings, so this way users have more freedom on how exactly results are displayed.
The variable can be used by other packages or hooks for additional processing of the result buffer, such as fontification or navigation.
Fuco1
force-pushed
the
feature/add-commands
branch
from
a907982
to
063809a
Compare
yyoncho
approved these changes
Mar 16, 2023
| @@ -243,11 +248,16 @@ PARAMS the params." | |||
| "Result set complete handler. | |||
| WORKSPACE is the active workspace. | |||
| PARAMS the params." | |||
| (-let* ((marker (lsp-mssql-with-result-buffer | |||
| (-let* ((column-info (gethash "columnInfo" (gethash "resultSetSummary" params))) | |||
There was a problem hiding this comment.
FWIW here we should start defining interfaces and using lsp-protocol.el otherwise it won't work with plists. I will let this in due to the fact that we are still using gethash and related on other places.
|
I added you as a maintainer. Feel free to push the trivial PRs directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-mssql-cancelto cancel current querylsp-mssql-format-regionto format the regionI also changed various display/pop commands to use
display-bufferwhich is user-configurable viadisplay-buffer-alist. For example, I have multiple monitors and I want the result set to be shown (not selected) on the second one if the window is already visible there, such that I can keep editing the queries without having to switch back-and-forth between windows.