Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullBus stategy #25

Merged
merged 4 commits into from
Apr 26, 2020
Merged

FullBus stategy #25

merged 4 commits into from
Apr 26, 2020

Conversation

erickskrauch
Copy link
Member

Resolves #24.

@erickskrauch
Extracted strategy from batch uuids provider implementation.
29b6bc8 
Reimplemented Periodic strategy.
Implemented FullBus strategy (#24).
Started working on tests.
@erickskrauch erickskrauch added this to the 4.5.0 milestone Apr 24, 2020
@erickskrauch erickskrauch self-assigned this Apr 24, 2020
@codecov-io
Copy link

codecov-io commented Apr 26, 2020 •
edited by codecov bot
Loading

Codecov Report

Merging #25 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   93.40%   93.70%   +0.29%     
==========================================
  Files          19       19              
  Lines        1077     1127      +50     
==========================================
+ Hits         1006     1056      +50     
  Misses         53       53              
  Partials       18       18
Impacted Files Coverage Δ
mojangtextures/batch_uuids_provider.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08bb23...30c0955. Read the comment docs.

@erickskrauch erickskrauch marked this pull request as ready for review April 26, 2020 14:56
@erickskrauch erickskrauch changed the base branch from master to 4.5.0 April 26, 2020 15:00
@erickskrauch erickskrauch merged commit d8f6786 into 4.5.0 Apr 26, 2020
@erickskrauch erickskrauch deleted the 24_batch_uuids_provider_strategies branch April 26, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erickskrauch erickskrauch

Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Add a new strategy for batch uuids queue which will perform request as soon as batch size limit will be filled
2 participants
@erickskrauch @codecov-io