CI configs: add nix flake #1815
Conversation
|
|
||
| [mod] | ||
| [mod."github.com/creack/pty"] | ||
| version = "v1.1.21" |
There was a problem hiding this comment.
How will this dependency data be kept in sync with the go.mod file? If someone submits a change that updates the version of any of these packages (which I have done more than once) do they also have to update this file or is file somehow automatically kept in sync with the go.mod file for the project?
There was a problem hiding this comment.
This has to be updated together with the command
nix develop --command gomod2nix.
If adding flake is OK, I'll try to add workflow that generates automatic PR when dependancy changes.
|
Hi, sorry for not getting to this. I've wanted to try Nix for a while, so I've been sitting on this PR thinking that I'd get to it once I learned enough Nix to understand what's going on. But it's taken a bit too long, so I thought I should at least post a response. I try to ensure that I can maintain the entire Elvish codebase, so in general I don't accept code that I don't fully understand unless there's a very compelling reason to do so. Can you tell me:
|
elvish is already packaged in nix, but adding flake file in the project can provide reproducible build, develop environment.
And helpful for someone who wants to package any version of elvish they want (nightly build or even fork..).