Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zoom to Fit #55

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix Zoom to Fit #55

merged 2 commits into from
Oct 13, 2023

Conversation

mohdali
Copy link
Member

@mohdali mohdali commented Oct 13, 2023

Fix zoom to fit #48 by removing the fixed height of 1000 and setting the container with 100% height so the graph will always fit the containing space.

=== auto-pr-body ===

Summary
This pull request seeks to address and refactor related flowchart components such as create-graph.ts, zoom-to-fit.ts, FlowchartDesigner.razor and FlowchartDesignerWrapper.razor to improve clarity and modularity of the code.

List of changes

  • Removed duplicate height and width attributes from create-graph.ts
  • Added minScale and maxScale attributes to zoom-to-fit.ts
  • Changed width and height attributes on FlowchartDesigner.razor and FlowchartDesignerWrapper.razor from explicit values to 100%

Refactoring Target

  • Split the FlowchartDesignerWrapper.razor components into separate components for read-only and non-read-only to make them more modular and reusable.
  • Refactor the zoom-to-fit.ts to use ES6 object destructuring for better readability.
  • Add comments to shallow functions to improve clarity.

@mohdali mohdali changed the title Fix for #48 Fix Zoom to Fit Oct 13, 2023
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

@sfmskywalker sfmskywalker merged commit af3e63b into main Oct 13, 2023
2 checks passed
@sfmskywalker sfmskywalker deleted the v3-fix-zoom-to-fit branch October 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants