Optimize rendering of ActivityWrapper. #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents the contents of the MudBadge component to not be re-rendered, which ought to improve re-rendering of the custom element as a whole. However, it will not fix the re-rendering issue that is reported, given the fact that the entire custom element instance will be recreated by X6, when it receives the `stats` value.
raymonddenhaan
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the contents of the MudBadge component to not be re-rendered, which ought to improve re-rendering of the custom element as a whole.
However, it will not fix the re-rendering issue that is reported, given the fact that the entire custom element instance will be recreated by X6, when it receives the
statsvalue.