Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scoping issues #4753

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix scoping issues #4753

merged 2 commits into from
Jan 5, 2024

Conversation

sfmskywalker
Copy link
Member

No description provided.

…ckgroundActivityScheduler

Removed explicit dependency resolution from the constructors of BackgroundTaskDispatcher and LocalBackgroundActivityScheduler classes, and used IServiceScopeFactory to resolve dependencies inside methods instead. Updated their lifetimes from Scoped to Singleton in the DI container in WorkflowRuntimeFeature. The DI container now manages the lifetime scope of these services, promoting better separation of responsibilities and improved testability.
@sfmskywalker sfmskywalker merged commit 480b726 into main Jan 5, 2024
1 check passed
@sfmskywalker sfmskywalker deleted the scope-fixes branch January 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant