Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus Activities enhancements - Workflow Inbox and Test #4512

Merged

Conversation

jdevillard
Copy link
Contributor

This PR add integration testing for Azure Service Bus Activities.
This PR also modify the Azure Service Bus activities to use the WorkflowInbox

@jdevillard jdevillard added the elsa 3 This issue is specific to Elsa 3 label Oct 9, 2023
@jdevillard
Copy link
Contributor Author

I don't know why all the GUID in the SLN have change ? maybe a mismatch version of my VS2022?

@sfmskywalker
Copy link
Member

Indeed, quite strange that it would do that. But as long as the projects and their references remain in tact, I don't think it's an issue.

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace Moq with another mocking package, such as NSubstitute or FakeItEasy.

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance 👍🏻

@jdevillard
Copy link
Contributor Author

ok SLN conflict is resolved ! if ok for you for the guid change in Sln , seems to be good and this could be merge.

@sfmskywalker sfmskywalker merged commit fb68814 into elsa-workflows:v3 Oct 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elsa 3 This issue is specific to Elsa 3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants