-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: top and bottom padding of small preview card on mobile #974
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ayoayco I added the |
Oh hmm yeah that doesn't look good without padding top/bottom |
I will add a condition to handle big cards |
@ayoayco I think we also need the padding on small cards. On the bottom here there should be a bit more padding, no? |
To my eyes this is okay, but will try to find a balance for the thumbnail size as well |
@patak-dev found a happy balance: made square thumbnail tiny-bit bigger and this puts more space for the small preview info description Also for big preview card we get to keep the p4 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fix for the thumbnail appears not filling up the height of the small preview cards on mobile