-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: totally hide strict filters #948
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I like that once preprocessed, we avoid dealing with these posts. One issue here is that if the user changes a strict filter, then a reload is needed to show these posts but I think the tradeoff is ok here. |
This branch already works (so if there's more demand it can be merged), but I plan to refactor it.
I'm looking to implement this suggestion in the previous comment by @patak-dev |
Lets do the refactoring first, no rush |
As discussed on the #ux channel, there is more demand to totally hide filtered posts when the FilterAction is 'hide'
This PR will
context
for the paginatorreorderedTimeline
functionreorderedTimeline
functionChanges 2-4 are needed for when the feature
virtualScroller
is true, because it adds an emptyDynamicScroller
Also, some initial styling fix for warning filters if it is a DM:
Handle contexts: