-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alt button covers audio play button #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ayoayco
changed the title
fix: alt button covers media play action
fix: alt button covers media play button
Jan 9, 2023
ayoayco
changed the title
fix: alt button covers media play button
fix: alt button covers audio play button
Jan 9, 2023
patak-dev
approved these changes
Jan 9, 2023
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #809
A bit of a quick fix for now. This PR will put the ALT button to the side for audio attachments
Test audio post: https://deploy-preview-911--elk-zone.netlify.app/mstdn.social/@feditips/109644044918079289
Tested video, GIF, and images--they should stay the same (see screenshots at the bottom)
Other media types should stay the same
Video: https://deploy-preview-911--elk-zone.netlify.app/mas.to/@ayodev/109660045793754684
GIF: https://deploy-preview-911--elk-zone.netlify.app/mas.to/@ayodev/109660075909387316
Image: https://deploy-preview-911--elk-zone.netlify.app/fosstodon.org/@viteconf/109659720641159906