Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: StatusSpoiler filter value type #380

Merged
merged 2 commits into from
Dec 8, 2022
Merged

fix: StatusSpoiler filter value type #380

merged 2 commits into from
Dec 8, 2022

Conversation

ayoayco
Copy link
Member

@ayoayco ayoayco commented Dec 8, 2022 •
edited
Loading

This PR will fix the console warning for wrong type of value to StatusSpoiler prop filter

@stackblitz
Copy link

stackblitz bot commented Dec 8, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit e54fa85
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6392076ee985b9000982a53c
😎 Deploy Preview https://deploy-preview-380--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayoayco ayoayco marked this pull request as draft December 8, 2022 15:33
@ayoayco
Copy link
Member Author

ayoayco commented Dec 8, 2022

Will refactor

@ayoayco ayoayco closed this Dec 8, 2022
@ayoayco ayoayco reopened this Dec 8, 2022
@ayoayco ayoayco marked this pull request as ready for review December 8, 2022 15:49
@ayoayco ayoayco changed the title fix: StatusSpoiler.action type fix: StatusSpoiler filter prop type Dec 8, 2022
@ayoayco ayoayco changed the title fix: StatusSpoiler filter prop type fix: StatusSpoiler filter value type Dec 8, 2022
@patak-dev patak-dev merged commit b0dae4f into main Dec 8, 2022
@patak-dev patak-dev deleted the fix/status-spoiler-action-type branch December 8, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoayco @patak-dev