Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sign-out and empty content #1654

Merged
merged 2 commits into from
Feb 6, 2023
Merged

fix: sign-out and empty content #1654

merged 2 commits into from
Feb 6, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 6, 2023

closes #1621

@stackblitz
Copy link

stackblitz bot commented Feb 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 6, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 9167c3d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63e0ee32bfd93a0008d6fcf1

@netlify
Copy link

netlify bot commented Feb 6, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 9167c3d
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63e0ee321eb75b0009e3e045
😎 Deploy Preview https://deploy-preview-1654--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin marked this pull request as ready for review February 6, 2023 12:10
danielroe
danielroe approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@danielroe danielroe merged commit f7a8d47 into main Feb 6, 2023
@danielroe danielroe deleted the userquin/fix-sign-out-no-content branch February 6, 2023 12:16
@boehs
Copy link
Member

boehs commented Feb 6, 2023

No more racing 😾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when sign-out with no more users main content is empty
3 participants
@userquin @boehs @danielroe