Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #main div stretching too much #1753

Merged
merged 1 commit into from
Mar 21, 2019
Merged

fix: #main div stretching too much #1753

merged 1 commit into from
Mar 21, 2019

Conversation

taj
Copy link
Member

@taj taj commented Mar 20, 2019

#main div stretches too much when very long strings without breaks are present, making the sidebar disappear out of view

Fixes #1751

@doomspork doomspork requested a review from a team March 20, 2019 22:02
@doomspork doomspork added the enhancement An enhancement to Elixir School content label Mar 20, 2019
Copy link
Member

@nscyclone nscyclone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @tajchumber!

@taj taj merged commit c421162 into master Mar 21, 2019
@gemantzu
Copy link
Contributor

Thanks @tajchumber !!! The only remnant of this I can still see is the first time you open the specific blog post and try to close the side panel, it insta-closes instead of doing the animation one. If you open another one, it works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to Elixir School content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants