-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT] Translation of Ecto associations lesson for Portuguese #1689
Conversation
You're awesome @lucaspbordignon! |
@doomspork Work finished! Can review at anytime! 😄 |
Thanks @lucaspbordignon! As soon as I get some time I'll review it! |
pt/lessons/ecto/associations.md
Outdated
## Configuração | ||
|
||
Nós vamos construir a aplicação `Example`, das ultimas lições. Você pode referir-se a configuração [aqui](./basics.md) para | ||
uma breve recapitulação. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucaspbordignon could you remove this line break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucaspbordignon pretty solid translation! Congratulations!!! 🚀 🤘
I just commented a few minor considerations, could you please take a look?
pt/lessons/ecto/associations.md
Outdated
## Tipos de Associações | ||
|
||
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como | ||
impementar cada um dos tipos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo %s/impementar/implementar
pt/lessons/ecto/associations.md
Outdated
|
||
## Tipos de Associações | ||
|
||
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to keep it in the same line?
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como | |
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como implementar cada um dos tipos. |
Then ✂️ line below.
@thiamsantos @wevtimoteo Thank you for the comments! I'm sorry for the delay in fixing those issues, but all of them were very significant. I've done all the changes on a single commit, to be easier for you to update your reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucaspbordignon Awesome!!! 🚀 🤘 🎉
@lucaspbordignon Let's just wait for @wevtimoteo take a another look on this before we can merge 😉 |
Thanks @lucaspbordignon!!!! 🚀 |
Translating the associations to pt-BR