Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT] Translation of Ecto associations lesson for Portuguese #1689

Merged
merged 5 commits into from
Feb 28, 2019

Conversation

lucaspbordignon
Copy link
Contributor

@lucaspbordignon lucaspbordignon commented Jan 14, 2019

Translating the associations to pt-BR

@lucaspbordignon lucaspbordignon changed the title [PT] Translation of Ecto associations lesson for Portuguese [PT][WIP] Translation of Ecto associations lesson for Portuguese Jan 14, 2019
@doomspork doomspork requested a review from a team January 14, 2019 22:47
@doomspork doomspork added translation The translation of Elixir School content WIP A work in progress labels Jan 14, 2019
@doomspork
Copy link
Member

You're awesome @lucaspbordignon!

@lucaspbordignon lucaspbordignon changed the title [PT][WIP] Translation of Ecto associations lesson for Portuguese [PT] Translation of Ecto associations lesson for Portuguese Feb 4, 2019
@lucaspbordignon
Copy link
Contributor Author

@doomspork Work finished! Can review at anytime! 😄

@anderkonzen
Copy link
Member

Thanks @lucaspbordignon! As soon as I get some time I'll review it!

## Configuração

Nós vamos construir a aplicação `Example`, das ultimas lições. Você pode referir-se a configuração [aqui](./basics.md) para
uma breve recapitulação.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaspbordignon could you remove this line break?

Copy link
Member

@thiamsantos thiamsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaspbordignon pretty solid translation! Congratulations!!! 🚀 🤘

I just commented a few minor considerations, could you please take a look?

pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
pt/lessons/ecto/associations.md Outdated Show resolved Hide resolved
## Tipos de Associações

Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como
impementar cada um dos tipos.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo %s/impementar/implementar


## Tipos de Associações

Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to keep it in the same line?

Suggested change
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como
Existem três tipos de associações que podem ser definidas entre nossos esquemas. Vamos dar atenção ao que elas são e como implementar cada um dos tipos.

Then ✂️ line below.

@lucaspbordignon
Copy link
Contributor Author

@thiamsantos @wevtimoteo Thank you for the comments! I'm sorry for the delay in fixing those issues, but all of them were very significant.

I've done all the changes on a single commit, to be easier for you to update your reviews.

Copy link
Member

@thiamsantos thiamsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaspbordignon Awesome!!! 🚀 🤘 🎉

@thiamsantos
Copy link
Member

@lucaspbordignon Let's just wait for @wevtimoteo take a another look on this before we can merge 😉

@thiamsantos thiamsantos merged commit 84e4a31 into elixirschool:master Feb 28, 2019
@thiamsantos
Copy link
Member

Thanks @lucaspbordignon!!!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation The translation of Elixir School content WIP A work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants