Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong underlined texts #23

Closed
Tracked by #66
gscdev opened this issue Oct 26, 2020 · 4 comments
Closed
Tracked by #66

Wrong underlined texts #23

gscdev opened this issue Oct 26, 2020 · 4 comments
Assignees
@gscdev
Labels
bug Something isn't working

Comments

@gscdev
Copy link
Member

gscdev commented Oct 26, 2020 •
edited by nya-elimu
Loading

Some underlined texts do not correspond to words
@gscdev gscdev added the bug Something isn't working label Oct 26, 2020
@nya-elimu nya-elimu mentioned this issue Oct 27, 2020
Closed
@nya-elimu
Copy link
Member

Relates to #28

@nya-elimu
Copy link
Member

nya-elimu commented Dec 16, 2020 •
edited
Loading

Occurs when previous paragraph(s) do not have any words (storyBookParagraphGson.getWords() == null).

If, for example, there are 3 paragraphs in the chapter, and only the last chapter contains a list of words that correspond to the paragraph's text (originalText). In this case, spannableStart and spannableEnd are not implemented correctly, causing the Spannables to be assigned to the 1st paragraph instead of the 3rd paragrah:

device-2020-12-16-212324

@gscdev gscdev self-assigned this Feb 11, 2021
gscdev added a commit that referenced this issue Feb 14, 2021
@gscdev
#23 fix wrong underlined texts
c420c2f
@gscdev
Copy link
Member Author

gscdev commented Feb 14, 2021

image

@nya-elimu
Copy link
Member

@gscdev This is amazing! Thank you very much for implementing this bug fix 🙂

@nya-elimu nya-elimu mentioned this issue Feb 16, 2021
Closed
gscdev added a commit that referenced this issue Feb 16, 2021
@gscdev
#23 replace pargraphIndex with paragraphIndex
295b824
gscdev added a commit that referenced this issue Feb 17, 2021
@gscdev
Merge pull request #75 from elimu-ai/23-Wrong-underlined-texts
725cd46 
#23 fix wrong underlined texts
@gscdev gscdev closed this as completed Feb 17, 2021
@nya-elimu nya-elimu mentioned this issue May 25, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gscdev gscdev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gscdev @nya-elimu