Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse ACL change Events #2782

Closed
ara4n opened this issue Feb 5, 2021 · 9 comments
Closed

Collapse ACL change Events #2782

ara4n opened this issue Feb 5, 2021 · 9 comments
Assignees
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@ara4n
Copy link
Member

ara4n commented Feb 5, 2021

Server ACLs can make for unpleasant reading. Like web, we should hide the details by default. Users can go into View Source if they really want to see the gory details

@bmarty
Copy link
Member

bmarty commented Feb 5, 2021

This should only show the details if you enable the developer mode.

@bmarty
Copy link
Member

bmarty commented Feb 5, 2021

Ok, now I understand that several ACL events are in the timeline and this is ugly. We have the same pb on Element Web:

image

@anoadragon453
Copy link
Member

Collapsing into moderator changed the server ACLs for this room 13 times, analogous to how Element clients handle displayname changes, sounds like a plausible route.

@SimonBrandner
Copy link

I am not sure how much effort this requires but it might be worth doing this now because of the recent spam attacks. Element Web did this recently

@bmarty
Copy link
Member

bmarty commented Jun 30, 2021

This is clearly something to do one day, and this should not be too hard to do it, but the priority is not high enough to do it now.

@bmarty bmarty changed the title Hide ACL change details by default Collapse ACL change Events Feb 4, 2022
@bmarty
Copy link
Member

bmarty commented Feb 4, 2022

On Element Web we can see this:

image

We already have the mechanism to collapse similar Events, it's should not take long to do it for ACL Events

@bmarty bmarty added this to the WTF ready list milestone Feb 4, 2022
@bmarty bmarty added A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Z-WTF WTF moment: High Impact, Low Effort T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Feb 4, 2022
@daniellekirkwood daniellekirkwood added this to WTFs & Papercuts in Android App Team Feb 9, 2022
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 10, 2022
@mnaturel mnaturel self-assigned this Feb 16, 2022
@mnaturel mnaturel moved this from WTFs & Papercuts to In progress in Android App Team Feb 16, 2022
@mnaturel
Copy link
Contributor

Hi @bmarty , do you know how server ACLs changes events can be generated in a room for testing purpose ?

@mnaturel mnaturel moved this from In progress to In Design Review in Android App Team Feb 17, 2022
@mnaturel
Copy link
Contributor

Hi @amshakal , my PR is now ready for design review. You can see how it renders in #5249 .

bmarty added a commit that referenced this issue Feb 18, 2022
…-events

#2782: Collapse server ACLs update events
@bmarty
Copy link
Member

bmarty commented Feb 18, 2022

Implemented in EA 1.4.2

@bmarty bmarty closed this as completed Feb 18, 2022
Android App Team automation moved this from In Design Review to Merged Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
Development

No branches or pull requests

7 participants