Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't know how to resole the lint error i m getting #1559

Closed
wants to merge 3 commits into from
Closed

I don't know how to resole the lint error i m getting #1559

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
774fcc0
#1557 feature request clear console CTRL+K
hachimetsu Mar 12, 2024
4908f3e
trying again after removing lint error
hachimetsu Mar 12, 2024
607a9a6
Update src/renderer/components/output.tsx
hachimetsu Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trying again after removing lint error
  • Loading branch information
@hachimetsu
hachimetsu committed Mar 12, 2024
commit 4908f3ee3258173cae3de12d0d3bc200f0a53547
14 changes: 7 additions & 7 deletions src/renderer/components/output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ export const Output = observer(
openerService: this.openerService(),
},
);
/**
* TODO: Clear Console on CTRL + K.
*/
if(this.editor){
this.editor.addCommand(MonacoType.KeyMod.CtrlCmd | MonacoType.KeyCode.KEY_K, () => {
if(this.model) this.model.setValue("Console Cleared !");
});
if (this.editor) {
this.editor.addCommand(
MonacoType.KeyMod.CtrlCmd | MonacoType.KeyCode.KEY_K,
() => {
if (this.model) this.model.setValue('Console Cleared !');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'd want a message when clearing the console. 😅

Copy link
Author

@hachimetsu hachimetsu Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that mean i m doing right ?
or i m doing something else which is not actually required ?
what if i do if (this.model) this.model.setValue("");

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i did use this this.model.setValue('Console Cleared !'); because i use CTRL+L orCTRL+SHIFT+L
it will move the cursor to the top of the terminal window and clear all the text that was previously displayed.
However, it doesn't erase the command history; you can still scroll up to see previous commands and output.

hachimetsu marked this conversation as resolved.
Show resolved Hide resolved
},
);
}
}
}
Expand Down
Loading