Cannot find module 'dmg-license' #6520
Comments
|
Hi, @robertpatrick exactly. May be I'm wrong please checkout the source code may be something wrong where in current release imported 'dmg-license' into the same package in 'dmgLicense.ts' which was removed in v29 |
|
@pranavwani But it is still there in master… |
|
Actually I thought this is the problem that module imported in its own source code 'dmg-license' into in its source code may be which will be fixed in upcoming release v29 I've test with Electron-Builder Version: 22.14.5 Still need to figure out |
|
@rpatrick00 any other possible solution? |
|
@pranavwani While I'm not using yarn, my current project (https://github.com/oracle/weblogic-toolkit-ui) is using electron-builder and we are not seeing this problem. There is a smaller example at https://github.com/robertpatrick/electron-updater-example (a fork from another project) that you could try out to see if it works for you. |
|
Thanks for sharing @rpatrick00. I'll check it out And happy new year 🎉 |
|
Temporary fix by set dependency Electron updater: v4.3.9 |
|
@pranavwani The other option is to move to the |
|
Yeah this should work. Just need to check thanks |
|
I got a similar error: |
|
@lyswhut try to check following solutions |
|
I got it working again: #6471 (comment) |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@mmaietta I think this is resolved so you can close it |
Cannot find module 'dmg-license' when building Electron app electron-userland/electron-builder#6520
Cannot find module 'dmg-license' when building Electron app electron-userland/electron-builder#6520 cf. electron-userland/electron-builder#6489 (comment) https://github.blog/changelog/2021-09-29-github-actions-jobs-running-on-macos-latest-are-now-running-on-macos-big-sur-11/
|
For anyone who lands here like me. This issue is not really resolved, and it is not really so much an issue with this module. But it is an issue nonetheless. This happens to me all the time due to the way I update dependencies. Usually, I delete my package-lock.json and node modules, and then I reinstall. This recreates the package-lock.json file with all the latest modules, respecting semver. If tests pass, there's a good chance everything is still fine. Problem solves, right? Well, this is where the issue described here occurs. I develop on Windows (sometimes even Linux), but never a Mac. This project, however, has optional dependencies that install only on a Mac. Well... guess what happens when I create my package-lock.json file on Windows? Those optional dependencies are missing. Or... at least the dependencies of those optional dependencies are missing. Later, when the project is installed on a Mac (like in CI), it fails to install those missing dependencies, and building fails. Since I forget every time and have to search for it, here is how I fix it (without a Mac... if you have a Mac, just generate a package-lock.json file there):
When looking at your package-lock.json file, now you should see that As for who actually needs to fix what: I have no clue 🤷♀️. This is probably an npm bug? |
|
Seems like a bad interaction between package-lock.json and optional packages to me… |
This comment is absolutely spot on. Thank you for shedding some light and giving a solution 🔥 |
|
Hi, It is reproduced on Linux with with adding leads to another error Changing to linux in package.json leads to
not sure if it is me trying to emit an dmg on Linux or a bug in last versions. |
|
I had the same issue with npm install "dmg-license" --save-optionalThis adds following lines to package.json: "optionalDependencies": {
"dmg-license": "^1.0.11"
}, |
- Migrate from "Vue 2.X" to "Vue 3.X"
- Migrate from "Vue Test Utils v1" to "Vue Test Utils v2"
Changes in detail:
- Change `inserted` to `mounted`.
- Change `::v-deep` to `:deep`.
- Change to Vue 3.0 `v-modal` syntax.
- Remove old Vue 2.0 transition name, keep the ones for Vue 3.0.
- Use new global mounting API `createApp`.
- Change `destroy` to `unmount`.
- Bootstrapping:
- Move `provide`s for global dependencies to a bootsrapper from
`App.vue`.
- Remove `productionTip` setting (not in Vue 3).
- Change `IVueBootstrapper` for simplicity and Vue 3 compatible API.
- Add missing tests.
- Remove `.text` access on `VNode` as it's now internal API of Vue.
- Import `CSSProperties` from `vue` instead of `jsx` package.
- Shims:
- Remove unused `shims-tsx.d.ts`.
- Remove `shims-vue.d.ts` that's missing in quickstart template.
- Unit tests:
- Remove old typing workaround for mounting components.
- Rename `propsData` to `props`.
- Remove unneeded `any` cast workarounds.
- Move stubs and `provide`s under `global` object.
Other changes:
- Add `dmg-license` dependency explicitly due to failing electron builds
on macOS (electron-userland/electron-builder#6520,
electron-userland/electron-builder#6489). This was a side-effect of
updating dependencies for this commit.
- Migrate from "Vue 2.X" to "Vue 3.X"
- Migrate from "Vue Test Utils v1" to "Vue Test Utils v2"
Changes in detail:
- Change `inserted` to `mounted`.
- Change `::v-deep` to `:deep`.
- Change to Vue 3.0 `v-modal` syntax.
- Remove old Vue 2.0 transition name, keep the ones for Vue 3.0.
- Use new global mounting API `createApp`.
- Change `destroy` to `unmount`.
- Bootstrapping:
- Move `provide`s for global dependencies to a bootsrapper from
`App.vue`.
- Remove `productionTip` setting (not in Vue 3).
- Change `IVueBootstrapper` for simplicity and Vue 3 compatible API.
- Add missing tests.
- Remove `.text` access on `VNode` as it's now internal API of Vue.
- Import `CSSProperties` from `vue` instead of `jsx` package.
- Shims:
- Remove unused `shims-tsx.d.ts`.
- Remove `shims-vue.d.ts` that's missing in quickstart template.
- Unit tests:
- Remove old typing workaround for mounting components.
- Rename `propsData` to `props`.
- Remove unneeded `any` cast workarounds.
- Move stubs and `provide`s under `global` object.
Other changes:
- Add `dmg-license` dependency explicitly due to failing electron builds
on macOS (electron-userland/electron-builder#6520,
electron-userland/electron-builder#6489). This was a side-effect of
updating dependencies for this commit.
Stack
The text was updated successfully, but these errors were encountered: