Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant compile-time def #565

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

scolsen
Copy link
Contributor

@scolsen scolsen commented Feb 7, 2023

Removes a redundant compile-time definition in the cmake toolchain file. STM32H750xx was set twice, once in a bundle of other definitions, and a second time by itself.

Removes a redundant compile-time definition in the cmake toolchain file. STM32H750xx was set twice, once in a bundle of other definitions, and a second time by itself.
@stephenhensley
Copy link
Collaborator

@scolsen sorry for the delay in getting to this, but looks sensible to me!
thanks for the PR!

@stephenhensley stephenhensley merged commit 5f1d862 into electro-smith:master Mar 24, 2023
scolsen added a commit to scolsen/libDaisy that referenced this pull request Apr 12, 2023
Removes a redundant compile-time definition in the cmake toolchain file. STM32H750xx was set twice, once in a bundle of other definitions, and a second time by itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants