Add percentages to exchange tooltip #5791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Aug 29, 2023
There was a problem hiding this comment.
I have been hesitant to add this to the tooltip because I don't think there is a good way to do it (a way to do it without adding ambiguity or confusion).
The current implementation for example does not always match what you expect it to if you compare it to the horizontal bar breakdown graph. This is due to the fact that the net values are a weigted average and can't really be compared to the more granular data we have in the bar breakdown.
| <b> | ||
| {getRatioPercent( | ||
| Math.abs(netExchange), | ||
| netExchange >= 0 ? netConsumption : netProduction |
There was a problem hiding this comment.
This is not how these values are intended to be used, we should not switch between them like this. These should only be switched when using the production<->consumption toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the percentage of electricity that net exchanges represent to the net exchange tooltip.
I've decided to make it so that the percentage is calculated with the total electricity produced or total consumed based on whether the imports are positive or negative. I feel it is a more useful metric, and also avoids confusing users in some strange cases, e.g. country exports 50 % of electricity produced but it says 100 % of electricity available.
The PR is mostly done, but I'd need some help regarding translations.
Also, feel free to raise any issues about code style as this is my first time writing typescript.
Preview
It also works in the CO2 category:
I thought about changing the text in the case of being in the CO2 category but "CO2 available" seems a bit wrong. It would be interesting if someone came with some better text.
Check
pnpx prettier --write .andpoetry run formatto format my changes.