[WIP] Adds many more missing bounding boxes #5596
Conversation
It was getting heavily skewed due to an uninhabited island
github-actions
bot
added
frontend 🎨
zone config
| ); | ||
| const zoneKey = inputArguments[0]; | ||
|
|
||
| const zonesToCover = zoneKey === 'ALL' ? findZonesWithMissingBoundingBoxes() : [zoneKey]; |
There was a problem hiding this comment.
| const zonesToCover = zoneKey === 'ALL' ? findZonesWithMissingBoundingBoxes() : [zoneKey]; | |
| const zonesToCover = zoneKey === '--all' ? findZonesWithMissingBoundingBoxes() : [zoneKey]; |
I also think running ALL or --all should run on all zones, not just those with missing bounding boxes, for example to update modified zones. Goes hand in hand with a comment further down.
| if (zoneConfig.bounding_box) { | ||
| continue; | ||
| function findZonesWithMissingBoundingBoxes(): string[] { | ||
| const zoneConfig = mergeZones(); |
There was a problem hiding this comment.
You had to sneak in this before I we merged the other one didn't you? 😅
| // do not modifiy current bounding boxes | ||
| if (zoneConfig.bounding_box) { | ||
| console.error(`Ignoring ${zoneKey} as it already have a bounding box`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why do we want to ignore existing zones? If they have changed the bouding box should also be updated (like with the texas change).
| const averageBoundingBox: number[][] = [ | ||
| [200, 200], | ||
| [-200, -200], | ||
| ]; |
There was a problem hiding this comment.
Do we need a average bouding box or could we use a initial state of Number.NaN istead?
I think it would make more sense to start from zero so to speak.
Maybe call it temp bounding box insteade of average as well.
madsnedergaard
changed the title
madsnedergaard
added
the
change requested
Issue
Follow up to #1328
Description
Turns out there were a lot of zones that also didn't have bounding boxes 😅
Guess it's less important when we don't have data for the zones, but we might as well just add the bounding boxes now so that they are ready for when we have parsers!
I also fixed a few odd ones and made the script able to detect missing boxes.
Impact: Since we exclude bounding boxes in frontend, it doesn't change anything. It might make the need to switch yaml parser library more urgent though :)
Preview
use https://geojson.io and open this geojson file with all the lines:
https://www.dropbox.com/s/arfylzh165nxje0/lines.geojson?dl=0