#5426 new CZ (CEPS) parser is missing pumping demand for pumped hydro #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frantisek12
commented
Jun 30, 2023
VIKTORVAV99
requested changes
Feb 7, 2024
Comment on lines
+100
to
+104
| data_tag = xml.find("data") | ||
| data_list: List[dict] = [] | ||
|
|
||
| if data_tag is not None: | ||
| for values in data_tag: |
There was a problem hiding this comment.
This whole looping over xml elements is filled with type errors. Not sure we can merge it as is.
Comment on lines
+107
to
+109
| consumption_with_pumping = float(values["value1"]) | ||
| consumption = float(values["value2"]) | ||
| date_time = values["date"] |
There was a problem hiding this comment.
Causing several issues here.
| @@ -68,6 +68,71 @@ def get_target_datetime(dt: datetime | None) -> datetime: | |||
| return dt | |||
|
|
|||
|
|
|||
| def fetch_consumption( | |||
There was a problem hiding this comment.
This should not be named fetch_consumption if it don't return the expected consumption element.
Should be renamed to get_consumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #5426
Description
fetch_consumption added and used to obtain pumping demand. fetch_consumption() not replaced in configuration for entsoe. Could be done if the format is correct. Please check
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.