This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Add tooltip to barbreakdown chart and style zonedetails a bit #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2022 16:25
tonypls
reviewed
Dec 20, 2022
| @@ -21,6 +26,13 @@ function BarBreakdownChart() { | |||
| const [displayByEmissions] = useAtom(displayByEmissionsAtom); | |||
| const { ref, width } = useRefWidthHeightObserver(); | |||
| const { __ } = useTranslation(); | |||
| const isMinSM = useBreakpoint('sm'); | |||
There was a problem hiding this comment.
Might be better to have this more descriptive? isSmallDevice or something?
There was a problem hiding this comment.
Suggested change
| const isMinSM = useBreakpoint('sm'); | |
| const isBiggerThanMobile = useBreakpoint('sm'); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a lot of very similar functionality when it comes to tooltips. I'd like to simplify a bit but since I was able to add this with quite little code, I think it's better to just carry on and take another look at tooltips in the future.
Preview
Screen.Recording.2022-12-20.at.16.18.17.mov