Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Zone Details: Header part 1 #23

Merged
merged 8 commits into from
Nov 10, 2022
Merged

Zone Details: Header part 1 #23

merged 8 commits into from
Nov 10, 2022

Conversation

Kongkille
Copy link

@Kongkille Kongkille commented Nov 10, 2022

Step in ELE-1341

Based on the updated visuals provided by Rasmus, which also changes the functionality slightly

image

@Kongkille
Copy link
Author

Github breaks because I added so many flags, i will do that separately

@Kongkille Kongkille marked this pull request as ready for review November 10, 2022 12:31
@madsnedergaard
Copy link
Member

A reminder for future: I think we should test UX of this carefully when we're further, as I'm a bit concerned of things jumping a lot between different zones and making comparison/scanning harder due to the "badges" being placed like this. Maybe it's not an actual problem, so let's not do something about it now - just want to make sure we remember to play around with this later :)

Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM

// TODO: add correct icon
return (
<div className="flex flex-row pl-2">
<Link className="mr-4 self-center text-3xl text-gray-400" to={goBackPath}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any use case where we use the goBackPath for anything but /map? Otherwise I'd remove the prop and just hardcode it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, we can always bring it back

@Kongkille
Copy link
Author

A reminder for future: I think we should test UX of this carefully when we're further, as I'm a bit concerned of things jumping a lot between different zones and making comparison/scanning harder due to the "badges" being placed like this. Maybe it's not an actual problem, so let's not do something about it now - just want to make sure we remember to play around with this later :)

Rasmus and I discussed this as well, the only thing jumping really would be the labels which we can quickly switch with the data. This design allows for any number of labels which may prove useful in the future.

@Kongkille Kongkille merged commit 0485ce4 into master Nov 10, 2022
@Kongkille Kongkille deleted the mk/add-zone-header branch November 10, 2022 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants