This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Adds state with atom and initial timecontroller UI #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kongkille
commented
Nov 7, 2022
Kongkille
commented
Nov 7, 2022
VIKTORVAV99
reviewed
Nov 7, 2022
|
Added functionality so that when you change the url parameter everything else updates as well |
tonypls
suggested changes
Nov 9, 2022
| @@ -0,0 +1,16 @@ | |||
| export enum TimeAverages { | |||
There was a problem hiding this comment.
I think time period is the right naming here, an average implies a mean value i.e. the average time to run a mile is 5 minutes. Here's more definitions of "time periods" https://www.britannica.com/dictionary/eb/3000-words/topic/periods-of-time
There was a problem hiding this comment.
We asked platform who suggested time averages
https://electricitymaps.slack.com/archives/C01PWQYKX2R/p1666948439485229
tonypls
approved these changes
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be reviewed per commit.
Issue
https://linear.app/electricitymaps/issue/ELE-1330/set-up-jotai-and-document-usage
Description
To sync across URL, localstorage and sessionstorage, I created a new atom which is based upon atomWithStorage and the raw code from atomWithHash.
There is some UI attached to this PR which could have been split out, but I don't think it's as controversial as the files in state.
Preview