This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Moves integration tests over and makes them work again #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it looks great and I'm mostly sold on going all in |
tonypls
approved these changes
Nov 2, 2022
|
I think unit tests will always have its place primarily for the non-component stuff but like Tony I am in favor of increasing the test coverage with component testing! We could even replace some of the e2e tests and just keep the key user navigation scenarios and known edge cases we want to watch out for in the e2e tests. |
madsnedergaard
deleted the
madsnedergaard/ele-1363-duplicate-current-e2e-tests
branch
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This duplicates the existing e2e tests, while converting them to TS and setting up commands, plugins, etc. They now work, but obviously fail because we don't have any functionality 😅
While doing this I also set up Cypress Component Testing which works really well, and I think we should consider moving a lot of the current integration tests to component tests instead.
Going all-in on component testing?
I'm even considering if we should go further and use component testing instead of unit tests (with Jest + Testing Library). It feels faster and nicer to work with, but we should explore this more later.
Small comparison:
Kapture.2022-11-02.at.08.28.38.mp4