Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Conversation

madsnedergaard
Copy link
Member

@madsnedergaard madsnedergaard commented Nov 1, 2022

Description

Use pnpm run deploy to update the website!
In future I'd love to also clean out this bucket when deploying, but that requires thinking a bit - so let's wait with that ¯\_(ツ)_/¯

I also decided to use beta.xxx instead of v2, as I don't think we should communicate this project as a "V2" - that would in my opinion require some user-facing changes :)
(Also why I have not mentioned this in electricitymaps#4731)

Preview

https://beta.electricitymaps.com/

@VIKTORVAV99
Copy link
Member

Just wanted to add that I agree on the naming, V2 should be reserved for a major functionality or data change. (Perhaps when we update all the carbon intensities to be zone/country specific and/or allow more/higher granularity production modes)

@VIKTORVAV99
Copy link
Member

You might want to change the version in package.json as well since it's currently 2.0.0?
I'd probably put it as 1.1.0-beta or something similar.

@madsnedergaard
Copy link
Member Author

You might want to change the version in package.json as well since it's currently 2.0.0? I'd probably put it as 1.1.0-beta or something similar.

Good point! I maybe took it to far, but now it's also bumping the version on deployment 😄
(figured it would be useful for debugging to be able to tell which version is live and that will be easier to do now)

Copy link

@tonypls tonypls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madsnedergaard madsnedergaard merged commit 4376709 into master Nov 4, 2022
@madsnedergaard madsnedergaard deleted the madsnedergaard/ele-1385-set-up-hosting-and-deploy-website-to-new branch November 4, 2022 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants