initial map setup

[tonypls]

Issue

Setup map

Should the MapStyle.json live in the map directory?
Do we want camel casing for all files even json?

[madsnedergaard]

Oh hey, it works! :party:

Should the MapStyle.json live in the map directory?

Hmm, it could also live in the assets/public folder instead?

Do we want camel casing for all files even json?
Good question 🤔

I don't have any specific preferences here - we could also go kebab-case for non-components and PascalCase for components? Doesn't seem like we can set up a rule for differentiating though.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/filename-case.md

[VIKTORVAV99]

We could do it if we name them something like <name>.component.tsx and add eslint overrides for *.component.tsx. It would make things very clear but create long file names so there are both pros and cons.

[tonypls]

I think this is a good approach and easy to remember,here

Filename
Name files with camelCase. E.g. utils.ts, map.ts etc.
Reason: Conventional across many JS teams.
When the file exports a component and your framework (like React) wants component to be PascalCased, use pascal case file name to match e.g. Accordion.tsx, MyControl.tsx.
Reason: Helps with consistency (little overthought required) and its what the ecosystem is doing.

I love kebabs but might be better to follow the more common pattern

[VIKTORVAV99]

Just curious about this one.
Is this just temporary or how does it work and why do we need it?

[tonypls]

So I think this is a required dep for react-map-gl but map-libre-gl does everything it was required for

[tonypls]

It is a bit curious, maybe I try delete it or add a comment explaining

[VIKTORVAV99]

Ah it's for the peer dependency, that makes sense, I have never seen it used before. 👍🏻

[VIKTORVAV99]

Linking this should be enough? https://visgl.github.io/react-map-gl/docs/get-started/get-started#using-with-a-mapbox-gl-fork

[madsnedergaard]

I think this is a good approach and easy to remember,here

Filename
Name files with camelCase. E.g. utils.ts, map.ts etc.
Reason: Conventional across many JS teams.
When the file exports a component and your framework (like React) wants component to be PascalCased, use pascal case file name to match e.g. Accordion.tsx, MyControl.tsx.
Reason: Helps with consistency (little overthought required) and its what the ecosystem is doing.

I love kebabs but might be better to follow the more common pattern

Sounds good to me :)
I also think xx.component.tsx will be too long (and not working with VSCode refactoring functionality). If we want to separate things in linting, we could probably also rely on .ts vs .tsx later on.

[madsnedergaard]

LGTM, we will most likely delete the MapStyle.json file later on anyway (when our geo-tooling is in place)