Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Speed-ups (shasum + poetry install caching) #91

Merged
merged 8 commits into from
Mar 3, 2021
Merged

Speed-ups (shasum + poetry install caching) #91

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7aab14e
Add command to lazy get the sha1 command
skovhus Mar 3, 2021
ecf803f
Remove duplicated function
skovhus Mar 3, 2021
7343ddc
Simplify yarn command detection
skovhus Mar 3, 2021
297f51c
Speed up poetry install
skovhus Mar 3, 2021
861ab16
Use the fastest shasum available (30% speedup)
skovhus Mar 3, 2021
50906a8
Log error if hashing takes more than 3 seconds
skovhus Mar 3, 2021
d67bb8d
Disable pylint warning (we like globals)
skovhus Mar 3, 2021
477454f
Update docstring
skovhus Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicated function
  • Loading branch information
@skovhus
skovhus committed Mar 3, 2021
commit ecf803f1c05579bee0999a6926c9727a7910169b
6 changes: 1 addition & 5 deletions brick/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import os
import shutil
import time
import subprocess

import arrow
import click
Expand All @@ -27,6 +26,7 @@
)
from .git import GIT_BRANCH
from .logger import logger, handler
from .shell import run_shell_command

docker_client = docker.from_env()

Expand All @@ -46,10 +46,6 @@
}


def run_shell_command(cmd: str, check=True):
return subprocess.check_output(cmd, shell=True, encoding="utf8",).rstrip("\n")


def is_yarn_install_command(cmd):
install_commands = ["yarn", "yarn install"]
# Strip flags and trim the string
Expand Down