ESQL: Drop unused parts of esql-core package #110174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops a bunch of unused code in the esql-core package that was used to power SQL and EQL. We copied it when we forked the shared ql code into esql-core. But we don't need it.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
There's a bunch more unused code but it's a bit more complex to untangle so I'm skipping it for now. |
luigidellaquila
approved these changes
Jun 26, 2024
alex-spies
approved these changes
Jun 26, 2024
Comment on lines
40
to
44
| entries.add(new Entry(Converter.class, DefaultConverter.NAME, DefaultConverter::read)); | ||
|
|
||
| entries.add(new Entry(Processor.class, ConstantProcessor.NAME, ConstantProcessor::new)); | ||
| entries.add(new Entry(Processor.class, HitExtractorProcessor.NAME, HitExtractorProcessor::new)); | ||
| entries.add(new Entry(Processor.class, BucketExtractorProcessor.NAME, BucketExtractorProcessor::new)); | ||
| entries.add(new Entry(Processor.class, ChainingProcessor.NAME, ChainingProcessor::new)); | ||
|
|
There was a problem hiding this comment.
I wonder if we use any processors from this class?
There was a problem hiding this comment.
I think none of them are used, yeah. But there weren't as easy to see so I didn't grab them in this PR.
Comment on lines
-169
to
-180
| public void testConfigurationOptionalFunction() { | ||
| UnresolvedFunction ur = uf(DEFAULT, mock(Expression.class)); | ||
| FunctionRegistry r = new FunctionRegistry( | ||
| def(DummyConfigurationOptionalArgumentFunction.class, (Source l, Expression e, Configuration c) -> { | ||
| assertSame(e, ur.children().get(0)); | ||
| return new DummyConfigurationOptionalArgumentFunction(l, List.of(ur), c); | ||
| }, "dummy") | ||
| ); | ||
| FunctionDefinition def = r.resolveFunction(r.resolveAlias("DUMMY")); | ||
| assertEquals(ur.source(), ur.buildResolved(randomConfiguration(), def).source()); | ||
| } | ||
|
|
There was a problem hiding this comment.
While a bit paranoid, maybe let's port this to EsqlFunctionRegistryTests rather than just forgetting about it; we don't use ConfigurationFunction anymore, but we do have (and use) EsqlConfigurationFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a bunch of unused code in the esql-core package that was used to power SQL and EQL. We copied it when we forked the shared ql code into esql-core. But we don't need it.