Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Allow another cancel message in test #110169

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 25, 2024

This causes the ESQL tests to be ok with a different cancellation message in the cancellation tests - this one is just as descriptive as the previous allowed ones though I'm not entirely sure where it comes from. But that's ok - it tells us the request is cancelled.

Closes #109890

This causes the ESQL tests to be ok with a different cancellation
message in the cancellation tests - this one is just as descriptive as
the previous allowed ones though I'm not entirely sure where it comes
from. But that's ok - it tells us the request is cancelled.

Closes elastic#109890
@nik9000 nik9000 requested a review from dnhatn June 25, 2024 21:28
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Jun 25, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nik9000 nik9000 added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 26, 2024
@elasticsearchmachine elasticsearchmachine merged commit fa89cbe into elastic:main Jun 26, 2024
15 checks passed
@nik9000 nik9000 deleted the esql_this_cancel_ok_too branch June 26, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] EsqlActionTaskIT testCancelEsqlTask failing
3 participants