Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete sentence from TSDS docs #110162

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove obsolete sentence from TSDS docs #110162

merged 1 commit into from
Jun 26, 2024

Conversation

lkts
Copy link
Contributor

@lkts lkts commented Jun 25, 2024

Example in question does not actually set custom look_ahead_time and this sentence mentions using three hours as a value for that setting which is actually not valid and confusing.

@lkts lkts added >docs General docs changes auto-backport Automatically create backport pull requests when merged :StorageEngine/TSDB You know, for Metrics v8.13.5 v8.14.2 labels Jun 25, 2024
@lkts lkts requested a review from martijnvg June 25, 2024 20:39
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I think this is something I forgot to remove at a previous iteration of simplifying the getting started documentation.

@lkts lkts merged commit b68e7d7 into elastic:main Jun 26, 2024
6 checks passed
@lkts lkts deleted the fix_tsds_docs branch June 26, 2024 15:21
lkts added a commit to lkts/elasticsearch that referenced this pull request Jun 26, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.13
8.14

lkts added a commit to lkts/elasticsearch that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes :StorageEngine/TSDB You know, for Metrics Team:Docs Meta label for docs team Team:StorageEngine v8.13.5 v8.14.2 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants