Opt in number fields into fallback synthetic source when doc values are disabled #110160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
added
>enhancement
:StorageEngine/Mapping
|
Hi @lkts, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Jun 26, 2024
| if (preservesExactSource()) { | ||
| var rawInput = v.v1(); | ||
|
|
||
| // Confusing as it is this code actually runs |
There was a problem hiding this comment.
Nit: I'd skip the "Confusing as it is" part, it's all confusing.. Same below.
There was a problem hiding this comment.
Writing that made me feel better but i'll remove it.
kkrik-es
approved these changes
Jun 26, 2024
lkts
changed the title
lkts
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #109546.