Enable madvise by default for all builds #110159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
added
the
cloud-deploy
|
@elasticmachine update branch |
mark-vieira
reviewed
Jul 1, 2024
distribution/src/config/jvm.options
Outdated
| @@ -58,6 +58,9 @@ | |||
| # result in less optimal vector performance | |||
| 20-:--add-modules=jdk.incubator.vector | |||
|
|
|||
| # Enable random access flags via madvise | |||
| -Des.madv_random_feature_flag_enabled=true | |||
There was a problem hiding this comment.
I think typically when we want to enable something by default that was previously behind a feature flag, we simply remove the feature flag. In either case, I don't think we'd want this option in jvm.options but rather in SystemJvmOptions. @rjernst might provide more insight here.
There was a problem hiding this comment.
That's right, we should remove the feature flag to "enable" it permanently. If the intent is for users to be able to disable this, then it should be moved from a feature flag to a setting.
There was a problem hiding this comment.
roger! I will just remove the flag :)
benwtrent
removed
the
cloud-deploy
mark-vieira
approved these changes
Jul 9, 2024
ChrisHegarty
approved these changes
Jul 10, 2024
|
@elasticmachine update branch |
benwtrent
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature flag has been enabled by default for snapshot builds for some time, no significant bumps or changes in rally.
This commit will enable it by default, even in release builds.