Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Migrate all serialization of Expression #110157

Merged
merged 2 commits into from
Jul 2, 2024
Merged

ESQL: Migrate all serialization of Expression #110157

merged 2 commits into from
Jul 2, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 25, 2024

This moves all of Expression serialization from ESQL's home grown system into NamedWriteable which is how the rest of Elasticsearch works. We previously implemented NamedWriteable on all Expression subclasses and tested it. This just switches all production serialization over. It is wire compatible with the old custom way, so no one should notice anything other than less custom code.

@nik9000
ESQL: Migrate all serialization of Expression
d67151b 
This moves all of `Expression` serialization from ESQL's home grown
system into `NamedWriteable` which is how the rest of Elasticsearch
works. We previously implemented `NamedWriteable` on all `Expression`
subclasses and tested it. This just switches all production
serialization over. It is wire compatible with the old custom way, so
no one should notice anything other than less custom code.
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

ChrisHegarty
ChrisHegarty approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! LGTM

@nik9000 nik9000 added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 2, 2024
@elasticsearchmachine elasticsearchmachine merged commit 9282c1b into elastic:main Jul 2, 2024
15 checks passed
@nik9000 nik9000 deleted the esql_expression_named_writeable_final branch July 2, 2024 20:16
@dnhatn dnhatn mentioned this pull request Jul 3, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jul 3, 2024
@dnhatn
Fix serialization of to_partial and from_partial (#110403)
bc1b77f 
#110157 broke the serialization of ToPartial and FromPartial, where the 
parameters weren't properly assigned.

I will look into making these classes more compatible with 
AggregateFunction, but this small change should stabilize the CI.

Relates #110157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@bpintea bpintea Awaiting requested review from bpintea

@fang-xing-esql fang-xing-esql Awaiting requested review from fang-xing-esql

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticsearchmachine @ChrisHegarty