Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] Fix automatic tracking of collapse with docvalue_fields (#110103) #110154

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

benwtrent
Copy link
Member

Backports the following commits to 8.14:

There were some optimizations that broke collapse fields automatically
being added to `docvalue_fields` during the fetch phase. 

Consequently, users will get really weird errors like
`unsupported_operation_exception`. This commit corrects the intended
behavior of automatically including the collapse field in the
docvalue_fields context during fetch if it isn't already included.

closes: elastic#96510
@benwtrent benwtrent added :Search/Search Search-related issues that do not fall into other categories >bug auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Meta label for search team labels Jun 25, 2024
@benwtrent
Copy link
Member Author

Verified that elasticsearch-ci/rest-compatibility is actually green, just didn't update the pr. merging.

@benwtrent benwtrent merged commit d3efd51 into elastic:8.14 Jun 26, 2024
14 of 15 checks passed
@benwtrent benwtrent deleted the backport/8.14/pr-110103 branch June 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.14.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants