Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Move all remaining Expression serialization #110114

Merged
merged 3 commits into from
Jun 25, 2024
Merged

ESQL: Move all remaining Expression serialization #110114

merged 3 commits into from
Jun 25, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 24, 2024

To line it up with the rest of Elasticsearch.

@nik9000
ESQL: Move all remaining Expression serialization
d550e91 
To line it up with the rest of Elasticsearch.
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.15.0 labels Jun 24, 2024
@nik9000 nik9000 added >non-issue :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Jun 24, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@nik9000
Copy link
Member Author

nik9000 commented Jun 24, 2024

This is the last of the Expressions. We can remove writeExpression and readExpression after this. Those should just be writeNamedWriteable and readNamedWriteable. That's honestly most of PlanNamedTypes.

@nik9000
Copy link
Member Author

nik9000 commented Jun 25, 2024

run elasticsearch-ci/part-3

luigidellaquila
luigidellaquila approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nik9000 nik9000 merged commit ae32cb3 into elastic:main Jun 25, 2024
15 checks passed
@nik9000
Copy link
Member Author

nik9000 commented Jun 25, 2024

Thanks @luigidellaquila !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

@not-napoleon not-napoleon Awaiting requested review from not-napoleon

@bpintea bpintea Awaiting requested review from bpintea

@ChrisHegarty ChrisHegarty Awaiting requested review from ChrisHegarty

@fang-xing-esql fang-xing-esql Awaiting requested review from fang-xing-esql

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticsearchmachine @luigidellaquila