ESQL: Merge more of EsqlDataTypes into DataType #110105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves a few more methods from `EsqlDataTypes` into `DataType` and makes some of the followup changes recommended in elastic#109921.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
not-napoleon
approved these changes
Jun 26, 2024
| @@ -46,7 +52,7 @@ public DataType fromJava(Object value) { | |||
|
|
|||
| @Override | |||
| public boolean isUnsupported(DataType type) { | |||
| return EsqlDataTypes.isUnsupported(type); | |||
| return type == DataType.UNSUPPORTED; | |||
There was a problem hiding this comment.
Maybe we should just inline this too, while we're at it? Or in the next PR...
There was a problem hiding this comment.
It's used in a while bunch of places. Maybe we should, but I don't want to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a few more methods from
EsqlDataTypesintoDataTypeand makes some of the followup changes recommended in #109921.