Implement lucene pushdown on ST_DISTANCE #110102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>enhancement
:Analytics/Geo
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @craigtaverner, I've created a changelog YAML for you. |
|
Hi @craigtaverner, I've updated the changelog YAML for you. |
|
One thing I am missing is that we are not quantizing our data in the current implementation. I would expect that the test will be flacky when comparing the results? |
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108764 created the distance function, but without lucene pushdown to
geo_distance, this will be slow.This PR implemented this in a similar way to
geo_distance. That code uses the GeoDistanceQueryBuilder to create a lucene query for spatial intersection with a Circle geometry. This PR does a similar thing, but by creating an instance of theSpatialIntersectsfunction, which itself is optimized down to lucene using a similar spatial intersection.Benchmark results for 90th percentile latency:
Fixes #109972