Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL Search: simple re-ranking #110094

Merged
merged 7 commits into from
Jul 2, 2024
Merged

ES|QL Search: simple re-ranking #110094

merged 7 commits into from
Jul 2, 2024

Conversation

ioanatia
Copy link
Contributor

This is a prototype on how simple re-ranking.

Example:

SEARCH test [
              | WHERE id > 2
              | RANK MATCH(content, "quick brown dog")
              | RANK MATCH(content, "brown fox")
              ]
            | KEEP id, _score, content
            | LIMIT 100
            """

The second RANK will re-rank the top docs returned by the first RANK.

Notes:

  • limits are not pushed to rescorers for now
  • "custom" scoring function are not yet supported - we consider only the default Lucene scores for now

@ioanatia ioanatia marked this pull request as ready for review June 25, 2024 10:41
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 25, 2024
@ioanatia ioanatia added the :Search/Search Search-related issues that do not fall into other categories label Jun 25, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

ChrisHegarty
ChrisHegarty approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tteofili
tteofili approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ioanatia ioanatia merged commit f53b424 into elastic:esql/search Jul 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tteofili tteofili tteofili approved these changes

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioanatia @elasticsearchmachine @tteofili @ChrisHegarty