Fix vector similarity test failures for half-byte #110065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
added
auto-merge
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test that is set up assumes a single shard. Since the test uses so few vectors and few dimensions, the statistics are pretty sensitive.
CCS tests seem to allow more than one write shard (via more than one cluster). Consequently, the similarity detected can vary pretty wildly. However, through empirical testing, I found that the desired vector seems to always have a score > 0.0034 and all the other vectors have a score < 0.001. This commit adjusts this similarity threshold accordingly. This should make the test flakiness go away in CCS testing.
closes: #109881