Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test failure #110032 due to partial shard results #110062

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

benwtrent
Copy link
Member

The test was failing due to partial shard failure. We disallow partial shard failures so we get a failure as expected.

closes #110032

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v8.15.0 labels Jun 21, 2024
@benwtrent benwtrent requested a review from a team as a code owner June 21, 2024 19:51
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jun 21, 2024
@thecoop thecoop removed the request for review from a team June 24, 2024 08:25
@benwtrent benwtrent added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jun 25, 2024
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@benwtrent benwtrent merged commit 9a5c598 into elastic:main Jun 26, 2024
15 checks passed
@benwtrent benwtrent deleted the testfix/110032 branch June 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
5 participants