[ESQL] remove duplicate datatype functions #110060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
not-napoleon
commented
Jun 24, 2024
| @@ -162,7 +162,10 @@ public enum DataType { | |||
|
|
|||
| static { | |||
| Map<String, DataType> map = TYPES.stream().filter(e -> e.esType() != null).collect(toMap(DataType::esType, t -> t)); | |||
| map.put("date_nanos", DATETIME); | |||
There was a problem hiding this comment.
To explain a bit about what's going on with date nanos here - this mapping was not being used by ES|QL, as we use the lookup from EsqlDataTypes (which is what this PR is merging into DataType). I presume this is a left over mapping from SQL. We also don't want to treat date nanos as datetimes, since that will cause weird type compatibility issues. So, removing this legacy mapping is actually a step towards supporting nanosecond dates.
nik9000
approved these changes
Jun 24, 2024
| @@ -162,7 +162,10 @@ public enum DataType { | |||
|
|
|||
| static { | |||
| Map<String, DataType> map = TYPES.stream().filter(e -> e.esType() != null).collect(toMap(DataType::esType, t -> t)); | |||
| map.put("date_nanos", DATETIME); | |||
bpintea
reviewed
Jun 24, 2024
| @@ -32,29 +28,14 @@ | |||
|
|
|||
| public final class EsqlDataTypes { | |||
|
|
|||
| private static final Map<String, DataType> NAME_TO_TYPE = DataType.types() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two, slightly different, mappings from ES types to ES|QL types, in
EsqlDataTypesandDataType. This merges them, and removes other redundant duplicate data structures.